Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sbb-select): update displayed value on option label change #3300

Merged
merged 3 commits into from
Dec 16, 2024
Merged

fix(sbb-select): update displayed value on option label change #3300

merged 3 commits into from
Dec 16, 2024
+111 −20

Conversation

jeripeierSBB
Copy link
Contributor

Closes #3298

@github-actions github-actions bot added target: 2.x pr: peer review required A peer review is required for this pull request labels Dec 16, 2024
@github-actions github-actions bot requested a deployment to pr3300 December 16, 2024 08:57 In progress
@github-actions github-actions bot requested a deployment to pr3300-diff December 16, 2024 08:57 In progress
@github-actions github-actions bot requested a deployment to pr3300 December 16, 2024 09:32 In progress
@github-actions github-actions bot requested a deployment to pr3300-diff December 16, 2024 09:33 In progress
kyubisation
kyubisation approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Dec 16, 2024
@jeripeierSBB jeripeierSBB merged commit a089328 into main Dec 16, 2024
19 of 20 checks passed
@jeripeierSBB jeripeierSBB deleted the select-displayed-value-change branch December 16, 2024 15:53
@github-actions github-actions bot added pr: peer review required A peer review is required for this pull request and removed pr: peer review required A peer review is required for this pull request labels Dec 16, 2024
sbb-design-systems-bot bot pushed a commit that referenced this pull request Dec 16, 2024
@jeripeierSBB
fix(sbb-select): update displayed value on option label change (#3300)
3c2f3c5
@github-actions github-actions bot mentioned this pull request Dec 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyubisation kyubisation kyubisation approved these changes

Assignees
No one assigned
Labels
diff-available pr: lead review approved Pull request has been approved by a lead review pr: peer review required A peer review is required for this pull request pr: visual review required preview-available target: 2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: sbb-select's current value doesn't always properly update
2 participants
@jeripeierSBB @kyubisation