Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustls support no longer works with TLS 1.2 connections #176

Closed
charlespierce opened this issue Dec 10, 2024 · 0 comments · Fixed by #177
Closed

Rustls support no longer works with TLS 1.2 connections #176

charlespierce opened this issue Dec 10, 2024 · 0 comments · Fixed by #177

Comments

@charlespierce
Copy link
Contributor

With the recent upgrade of rustls in #175, the default features were correctly turned off to enable the ring cryptography provider. However, in the process, the default feature tls12 was not re-enabled. That feature adds support for TLS 1.2 connections, so at the moment using attohttpc with rustls we see a ProtocolVersion error when attempting to fetch from registry.npmjs.org. (See this CI failure)

Testing locally, it appears that re-enabling the tls12 feature solves the underlying issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant