Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rustls 'tls12' feature to continue to support TLS 1.2 connections #177

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

charlespierce
Copy link
Contributor

Closes #176

Info

  • The recent upgrade of the rustls dependency inadvertently removed the default feature tls12
  • The result is that the latest version of attohttpc doesn't support TLS 1.2 connections using Rustls as the underlying TLS provider.

Changes

  • Added tls12 to the list of re-enabled features in Cargo.toml

Tested

  • Locally verified that having the tls12 feature enabled allows connections to registry.npmjs.org (while those connections fail using the latest attohttpc version 0.28.1)

@sbstp sbstp merged commit 7a5814a into sbstp:master Dec 18, 2024
4 checks passed
@charlespierce charlespierce deleted the restore_rustls_tls12 branch December 18, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rustls support no longer works with TLS 1.2 connections
2 participants