Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to rustls 0.23.x #175

Merged
merged 1 commit into from
Dec 7, 2024
Merged

Upgrade to rustls 0.23.x #175

merged 1 commit into from
Dec 7, 2024

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Nov 25, 2024

Fixes #174

@jayvdb
Copy link
Contributor Author

jayvdb commented Nov 25, 2024

I am seeing the following error using this fork; investigating ..

   Compiling attohttpc v0.28.0 (https://github.com/jayvdb/attohttpc?branch=rustsec-rustls#10a6b032)
error[E0433]: failed to resolve: could not find `ring` in `crypto`
Error:    --> /work/home/.cargo/git/checkouts/attohttpc-f809b81887a3e425/10a6b03/src/tls/rustls_impl.rs:235:30
    |
235 |             &rustls::crypto::ring::default_provider().signature_verification_algorithms,
    |                              ^^^^ could not find `ring` in `crypto`
    |
note: found an item that was configured out
   --> /work/home/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rustls-0.23.18/src/crypto/mod.rs:26:9
    |
26  | pub mod ring;
    |         ^^^^
note: the item is gated behind the `ring` feature
   --> /work/home/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rustls-0.23.18/src/crypto/mod.rs:25:7
    |
25  | #[cfg(feature = "ring")]
    |       ^^^^^^^^^^^^^^^^
...

@jayvdb
Copy link
Contributor Author

jayvdb commented Nov 25, 2024

@jayvdb
Copy link
Contributor Author

jayvdb commented Nov 25, 2024

@sbstp , this is ready.

@jayvdb
Copy link
Contributor Author

jayvdb commented Dec 3, 2024

Ping @sbstp

@sbstp sbstp merged commit 7eae511 into sbstp:master Dec 7, 2024
4 checks passed
@jayvdb jayvdb deleted the rustsec-rustls branch December 8, 2024 05:36
@jayvdb jayvdb restored the rustsec-rustls branch December 8, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RUSTSEC-2024-0399: rustls 0.22.x
2 participants