Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite recursion with Compile packageBin #105

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mdedetrich
Copy link
Collaborator

@mdedetrich mdedetrich commented Jan 9, 2024

Resolves #104

Pinging @romainreuillon since #79 (comment) was the cause of the regression. @romainreuillon Can you confirm that this PR still solves the asynchronicity issue with package task?

@eed3si9n Since you know the sbt internals if you have time maybe you can comment on this (since at #79 (comment) you did mention that doing this can cause issues). See the linked issue for more info

@mdedetrich
Copy link
Collaborator Author

Hmm, so this PR is causing test-10-multi-project-dependsOn-includePackage-versions to fail, likely because of ordering issues will have to have a further look. In general the change in #79 (comment) looks like a hack/workaround that is causing more issues than it solves.

@mdedetrich
Copy link
Collaborator Author

So for test-10-multi-project-dependsOn-includePackage-versions to pass it actually needs (Compile / sbt.Keys.packageBin) := bundle.value.

This looks like I will have to go back to the drawing board, possible even abandoning #103 and using another solution (such as explodedJar's).

@eed3si9n
Copy link
Member

Commented on the issue - #104 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compile / sbt.Keys.packageBin := bundle.value can cause infinite recursive loop
2 participants