Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix make sure the package does not override the bundle #79

Closed
wants to merge 2 commits into from

Conversation

romainreuillon
Copy link
Contributor

On our build some bundle gets replaced by simple package due to the asynchronicity of the task. This makes sure that the package task is executed before the bundle one.

@mdedetrich mdedetrich requested a review from eed3si9n October 13, 2023 16:05
Copy link
Collaborator

@mdedetrich mdedetrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is lgtm but lets also see what @eed3si9n says

@eed3si9n
Copy link
Member

I honestly don't know how this plugin is being used, so I'd let you decide. I guess something to think about is potential impact of rewiring Compile / packageBin, which might be used by other plugins like sbt-native-packager or sbt-assembly. If so this would be a subtle breaking change that at least should be advertised as such in the release note.

@mdedetrich
Copy link
Collaborator

I think its safe to then leave this for a later release so not too much gets released at once.

@mdedetrich
Copy link
Collaborator

So due to #93 (comment) I am going to merge this now and then cut a release so that we can verify it fixes the regression that was introduced in 0.9.5

@mdedetrich mdedetrich mentioned this pull request Oct 21, 2023
@mdedetrich
Copy link
Collaborator

mdedetrich commented Oct 21, 2023

Closing this PR in favour of #95 because I don't have permissions on @romainreuillon branch in order to add a merge commit so this PR can be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants