Foundry v2

[jrcarlos2000]

Description

• Export contracts to Next Js regardless of verification result after yarn deploy:verify
• able to verify after deployment is done : cc @technophile-04

Additional Information

• I have read the contributing docs (if this is your first contribution)
• This is not a duplicate of any existing pull request

Related Issues

_Closes #470

Your ENS/address: jrcarlos2000.eth

[technophile-04]

I was trying to verify on polygonMumbai :

https://mumbai.polygonscan.com/address/0x4FaE2E1Dd219400328edAC56B3bc9F81bD6EE190

Also for some reason it's not verified yet

It just say you "submitted verification" and end the script there, I think we should probably wait for contract verification and once we get a response from etherscan then output the message with verified etherscan URL 😅

I don't how would be able to make network request / wait for a network request if it's at all possible similar to se-2 hardhat

[jrcarlos2000]

Yes, error logging is a TODO here. we can either run some checks after the script is done or while the script is running.

[technophile-04]

Tysm @jrcarlos2000, I have been testing it a bit it seems work 🙌

But for some reason, I get this :

As you can see logged the ERROR but the it was verified at the end

---

Also if there was error like I used Invalid API KEY it shows this :

I wonder if we could parse this nicely and show it on terminal ? Like Maybe just showing stderr=Encountered an error verifying this contract ? Like just showing nice messages which we alreay have in stderr, Response, Details maybe log only this three things ?

Also, it would be really great if we don't show "== Logs ==" if the thing failed 🙌

---

Also, I thinki there are warning like unsued VerifyAll.sol lets remove them

But Thanks again !! The functionality works nicely lets clean it up a bit 🙌 !!

[technophile-04]

Tysm @jrcarlos2000,

Just a few things :

1 . When we try to deploy intially we get warnings from Verify.sol :

2 . I think we should log the etherscan URL for verified contract or at least the address of contract which just got verfied

☝️ We don't see any address or etherscan URL of the contract which just got verified

When I was testing the verification of multiple contracts, it worked and also logged that one contract was already verified (since etherscan already found similar contract and verified it)

I like this logging !!, Would be really helpful if we also do something like this for point 2.

3 . If the user has put invalid etherscan api key :

We get this :( , Which is hard to debug. I think we should make it a lil verbose 🙌

[jrcarlos2000]

1 . When we try to deploy intially we get warnings from Verify.sol :
This has been corrected

2 . I think we should log the etherscan URL for verified contract or at least the address of contract which just got verfied
I have checked and i added a logging for the address being verified or verified, however is not possible to add the link to the verified contract unless we hardcode the URL values.

3 . If the user has put invalid etherscan api key :
I am not getting this error right now, if i put a wrong API KEY it would tell me it is invalid. seems to be a problem with just a few networks like goerli, if i put the wrong api key for mumbai, it shows me the error.

cc: @technophile-04

[technophile-04]

Hey Tysm @jrcarlos2000 !! Looking really great now !!

I tested it with a few different networks and working great!

Just a small case that i noticed while testing is,For some reason this only happens only on goerli and sepolia :

1. Add wrong etherscan API key in .env eg : ETHERSCAN_API_KEY=fsdfdssdf
2. Deploy the contract
3. While verifying it gives :
   

Instead of "Missing or invalid ApiKey"

Also, this problem is just with goerli and sepolia and maybe with mainnet but with other chains it gives nice error !

Nevertheless if it gets very hard to debug / require a very big change we can merge this and iterate over this issue on other PR, Because I think this PR already is looking alot better now & for chains like goerli/sepolia we already give etherscanAPI key so not big deal!!

[technophile-04]

Merging this 🙌, Regarding sepolia & goerli I think since we already porvide API_KEY people won't get into this trap but neverthe less as discussed in TG chat let's open this issue on foundry repo 🙌 & keep track of it

Tysm Carlos !!!