-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add npx project setup option #16
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Tysm Eda 🙌 !!
Just created scaffold-eth/scaffold-eth-2#508, maybe we can have a CLI section in the bottom of SE-2(
Yup makes sense!!. Alternatively also I was wondering what if we have it like this in the left sidebar? instead on single page : Quickstart
because having this will allow us maybe add a bit more details for just thinking out loud, but would love to know other's thought too 🙌 cc @Pabl0cks |
Nice job @edakturk14!! 🙌 I see a great idea to separate Installation in a different subsection now that we got 2 options for it, so is a bit more isolated and we don't have to replicate the common parts on both options (yarn chain, yarn deploy, yarn start). Maybe instead of "Getting Started" we can call that second subsection "Environment" like we did on the old SRE (we had Install+Environment sections), even if in new SRE-SE2 we merged both in a single "Environment" section, now I feel in here it makes sense to have Installation + Environment separated. What do you think in some structure like this?: QuickStartInstallationRequirementsOption 1: Setup using git cloneOption 2: [Beta] Setup using npx create-eth@latestEnvironmentNow that our installation is complete, we will set up our development environment for Scaffold ETH-2, which consists of three terminals:
|
Thank you both @technophile-04 & @Pabl0cks!! These are great suggestions! Let me work on the changes today. also definitely agree on updating the main se-2 readme once this PR is merged. We could have the same content there, instead of side bars it would be subheaders in that case - and we can make any iterations as needed. |
Please let me know what you think. One open questions that I have: Added a "What's next" section on the end of the environment (https://scaffold-eth-2-docs-ciuxg2nes-buidlguidldao.vercel.app/quick-start/environment#whats-next), we can change the name (eg: Further steps?) If this PR is good for you, I can the original se-2 readme in the same way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see changes nice! 🙌 Added some small comments.
Question for all (specially for future sections): Having now QuickStart parent not clickable I had doubts if users may get confused, but watching Docusaurus docs I see they also have some parents not clickable so I guess we will be fine :) Would love to hear your opinion too!
Question to @technophile-04: Do you think we should also work on adding Foundry explanations from cli branch into Docs right now? Or should we wait a bit?
Thanks ♥
Tysm Eda !! Looking great !
I love the idea of this section !! Maybe we could rearrange it a bit :
Yeah make sense! Just to keep consistency overall with others maybe we can do something similar to https://docs.scaffoldeth.io/category/-shipping-your-dapp ? What do you all think ?
Umm yeah I was actually thinking about it how we can add it in exsisting docs, maybe i will create an issue regarding adding Foundry explanantion in this docs once this scaffold-eth/scaffold-eth-2#489 PR is done 🙌 |
Great suggestions - I've made the grammar/typo + rearranging changes! Thanks a lot!!
Yeah now looking into it I agree that it can be confusing that the Quickstart it not clickable when the others are. I like the suggestion very much! What do you think @Pabl0cks?
sounds great! |
Yeah! That was my natural path, didn't feel rush since others were mixing clickable/non clickable, but for now I'd also continue having all sections clickable until we find a reason not to 😊🙌 |
made the updates, lmk what you think and happy to look into the missing parts @technophile-04 & @Pabl0cks |
Everything is cool for me! GJ Eda 🙌 I've just pushed a small tweak to make QuickStart clickable. Just learnt about |
Tysm Eda !!! and Thanks Pablo for the review !!, its looking really nice !! Merging this 🙌 |
Adding the npx setup option.