Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: add check before accessing cause.data in getParsedError #649

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

technophile-04
Copy link
Collaborator

Description

Screen.Recording.2023-12-07.at.8.49.47.PM.mov

Noticed while testing #648 and was introduced in #638 my bad 🤦‍♂️

I will also raise an issue on VIem so that in the future we don't need to assert typing manually and get proper typing from it directly when narrowed through ContractFunctionExecutionError

Copy link
Member

@carletex carletex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@carletex carletex merged commit 4a403ee into main Dec 7, 2023
1 check passed
@carletex carletex deleted the fix/readOnly-error branch December 7, 2023 16:10
@github-actions github-actions bot mentioned this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants