Fix useScaffoldContractWrite so it properly throws errors

[corwinthill]

Description

• These changes reflect what is summarized at the bottom of issue useScaffoldContractWrite does not throw errors #753
• Added line 88 to useScaffoldContractWrite.ts and changed line 98 in useTransactor.tsx
• These changes throw errors forward to a function utilizing useScaffoldContractWrite, and removes one notification error to prevent duplicate error notifications displaying.

Additional Information

• I have read the contributing docs (if this is your first contribution)
• This is not a duplicate of any existing pull request

Related Issues

Closes #753

Your ENS/address: zurriken.eth

[technophile-04]

Hey thanks @corwinthill 🙌, just pushed few tweaks :

Updated changes:

1. Just update useTransactor to show notification error + throw whole error forward

2. useScaffoldWriteContract's writeContractAsync will just throw error forward without showing any notifications.

Reason for above changes:

useTransactor:

The main aim of this hook is to execute given txn + show opinionated/general UI feedback, so it makes sense here to show error notification. Hence b036b23

useScaffoldWriteContract:

Since we are internally using useTransactor it should the show UI feedback needed but we don't need it to explicitly show error notification again and eat up the error.Similar to how wagmi's writeAsync works it should just throw error forward. Hence 2aace01

cc @carletex @rin-st for thoughts / any other suggestions

---

Since we are using useTransactor internally for useScaffoldWriteContract it makes UI feedback for useScaffoldWriteContract opinionated. Which kind of makes sense for beginners / intermediate users.

If advanced users want to show custom UI feedback they maybe shouldn't use useScaffoldWriteContract and use wagmi's useWriteContract and handle themselves.

But maybe in future we could make useScaffoldWriteContract less opinionated and let user handle the UI feedback themselves.

[damianmarti]

@corwinthill @technophile-04 This looks great!!

One related comment. Sometimes I ended up adding ifs to getParsedError, because the error thrown is not good enough, and you can get a better message checking something inside the error. Maybe adding a way to use a custom getParsedError is a nice way to improve that. What do you think? Did you have this issue before? We can move to a discussion if you think this is something we should implement...

[rin-st]

Lgtm!

[rin-st]

One related comment. Sometimes I ended up adding ifs to getParsedError, because the error thrown is not good enough, and you can get a better message checking something inside the error. Maybe adding a way to use a custom getParsedError is a nice way to improve that. What do you think? Did you have this issue before? We can move to a discussion if you think this is something we should implement...

Good point. I think we need to create a new issue for it, and your updates of getParsedError can be helpful. If you still have these projects somewhere of course :)

[technophile-04]

I think we need to create a new issue for it, and your updates of getParsedError can be helpful. If you still have these projects somewhere of course :)

++, Tysm Damu ! and also Rinat for reveiw! 🙌

Merging this

[damianmarti]

One related comment. Sometimes I ended up adding ifs to getParsedError, because the error thrown is not good enough, and you can get a better message checking something inside the error. Maybe adding a way to use a custom getParsedError is a nice way to improve that. What do you think? Did you have this issue before? We can move to a discussion if you think this is something we should implement...

Good point. I think we need to create a new issue for it, and your updates of getParsedError can be helpful. If you still have these projects somewhere of course :)

These are particular for each project/contract, you can take a look at https://github.com/damianmarti/fruit-market2/blob/main/packages/nextjs/components/scaffold-eth/Contract/utilsContract.tsx#L27