-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs with Wagmi v2 changes #61
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I think Damu's idea in #60 can be helpful for people wanting to migrate to latest SE-2 version, without having to check all details of wagmi v2 migration. Some doubts I had when I was documenting the changes:
Hope I haven't missed any changes, and that my explanations are not terrible 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TYSM @Pabl0cks !! This is really great !!!
Just pushed a few commits tried keeping them atomic so its easy to read, mainly revolving around :
- Distinguishing that contract interaction args are now passed to
writeContractAsync
instead ofuseSWC
eg: 38d8085, d0c172a - Wrapping
writeContractAsync
insidetry/catch
its important we mention this, earlier it not imp but after Fix useScaffoldContractWrite so it properly throws errors scaffold-eth-2#758 you should do it.- EG: Austin getting unhandled error on Next page (bottom left of his page) since he didn't wrap the function
I think this is nicely ready to merge along with scaffold-eth/scaffold-eth-2#700 🙌
Thanks for the awesome review @technophile-04!! Love all the improvements and learnt from the fixes 🙌 |
Merging this, we already merged scaffold-eth/scaffold-eth-2#700 Tysm @Pabl0cks again !! |
Creating this draft to start working on #60 to adapt docs to all changes involved with SE2 Wagmi v2 migration
Closes #60