-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use LLVM's YAML::IO library to read binding configuration #179
Open
jonas
wants to merge
1
commit into
master
Choose a base branch
from
yaml-config
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonas
commented
Aug 28, 2018
docs/src/paradox/using-bindings.md
Outdated
# Using Generated Bindings | ||
# Using Bindings | ||
|
||
The following will explain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfinished sentence
I will try to extract the documentation changed so those improvements can make it into 0.3.1 |
This was referenced Aug 28, 2018
kornilova203
reviewed
Sep 1, 2018
kornilova203
reviewed
Sep 1, 2018
static void mapping(llvm::yaml::IO &io, HeaderEntry &headerEntry) { | ||
io.mapRequired("path", headerEntry.path); | ||
io.mapRequired("object", headerEntry.object); | ||
io.mapOptional("names", headerEntry.names); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
jonas
force-pushed
the
yaml-config
branch
2 times, most recently
from
September 3, 2018 20:57
862b333
to
656aee0
Compare
Also improve the documentation of the binding configuration file with testable examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also improve the documentation of the binding configuration file with
testable examples.
Depends on #182