Improve the binding configuration documentation #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonas
force-pushed
the
binding-config-docs
branch
from
5d50cb1 to
3d0a59a
Compare
kornilova203
approved these changes
Sep 1, 2018
docs/src/paradox/configuration.md
Outdated
|
|
||
| ### Using Types From the Scala Native Bindings | ||
|
|
||
| Similar to the above, the following this example shows how you can use |
There was a problem hiding this comment.
I think this should not be here
| .name("stdlib") | ||
| .packageName("org.example.app.stdlib") | ||
| //#sbt-exclude-prefix | ||
| .excludePrefix("__") |
There was a problem hiding this comment.
I noticed that rendered snippet does not have indent on second line:
NativeBinding(resourceDirectory.value / "stdlib.h")
.excludePrefix("__")It can be fixed by changing comment indent:
.packageName("org.example.app.stdlib")
//#sbt-exclude-prefix
.excludePrefix("__")There was a problem hiding this comment.
this also applies to build.sbt:173
jonas
force-pushed
the
binding-config-docs
branch
from
3d0a59a to
4ba6d11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #179