Load Scalafix migrations from this repository #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes `MigrationAlg` so that it loads always the latest Scalafix migrations from this repository instead of using the static list of migrations that is shipped as resource in the JAR. The following changes with this PR: * The `--scalafix-migrations` option can now be used multiple times to load extra migrations not only from one but multiple files. * Arguments to the `--scalafix-migrations` cannot only be local files but also remote URLs. * Disabling loading the default Scalafix migrations is now done via a new `--disable-default-scalafix-migrations` option instead of using `disableDefaults` in an extra migrations file. * Scala Steward now prints how many Scalafix migrations it loaded at start-up. Closes: #1603
Codecov Report
@@ Coverage Diff @@
## master #1650 +/- ##
==========================================
- Coverage 71.69% 71.68% -0.02%
==========================================
Files 113 114 +1
Lines 1876 1875 -1
Branches 46 57 +11
==========================================
- Hits 1345 1344 -1
Misses 531 531
Continue to review full report at Codecov.
|
mzuehlke
approved these changes
Oct 9, 2020
Co-authored-by: Marco Zühlke <mzuehlke@gmail.com>
Co-authored-by: Marco Zühlke <mzuehlke@gmail.com>
fthomas
added a commit
that referenced
this pull request
Sep 23, 2021
This splits `ArtifactMigrations` into a loader and finder class. The former loads the latest artifact migrations from this repository instead of using the static list of migrations that is shipped as resource in the JAR. That means that all Scala Steward instances use the artifact migrations from this repository as soon as they are added here. The following changes with this PR: * The `--artifact-migrations` option can now be used multiple times to load extra migrations not only from one but multiple files. * Arguments to the `--artifact-migrations` cannot only be local files but also remote URLs. * Scala Steward prints how many artifact migrations it loaded at start-up. The same has been done for Scalafix migrations in #1650. Closes: #1963
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
MigrationAlgso that it loads always the latest Scalafixmigrations from this repository instead of using the static list of
migrations that is shipped as resource in the JAR.
The following changes with this PR:
--scalafix-migrationsoption can now be used multiple times toload extra migrations not only from one but multiple files.
--scalafix-migrationscannot only be local filesbut also remote URLs.
new
--disable-default-scalafix-migrationsoption instead of usingdisableDefaultsin an extra migrations file.start-up.
Closes: #1603