Load artifact migrations from this repository #2249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This splits `ArtifactMigrations` into a loader and finder class. The former loads the latest artifact migrations from this repository instead of using the static list of migrations that is shipped as resource in the JAR. That means that all Scala Steward instances use the artifact migrations from this repository as soon as they are added here. The following changes with this PR: * The `--artifact-migrations` option can now be used multiple times to load extra migrations not only from one but multiple files. * Arguments to the `--artifact-migrations` cannot only be local files but also remote URLs. * Scala Steward prints how many artifact migrations it loaded at start-up. The same has been done for Scalafix migrations in #1650. Closes: #1963
Codecov Report
@@ Coverage Diff @@
## master #2249 +/- ##
==========================================
+ Coverage 78.22% 78.29% +0.06%
==========================================
Files 132 135 +3
Lines 2273 2271 -2
Branches 55 55
==========================================
Hits 1778 1778
+ Misses 495 493 -2
Continue to review full report at Codecov.
|
exoego
reviewed
Sep 23, 2021
modules/core/src/main/scala/org/scalasteward/core/update/artifact/ArtifactChange.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits
ArtifactMigrationsinto a loader and finder class. Theformer loads the latest artifact migrations from this repository instead
of using the static list of migrations that is shipped as resource in
the JAR. That means that all Scala Steward instances use the artifact
migrations from this repository as soon as they are added here.
The following changes with this PR:
--artifact-migrationsoption can now be used multiple times toload extra migrations not only from one but multiple files.
--artifact-migrationscannot only be local filesbut also remote URLs.
start-up.
The same has been done for Scalafix migrations in #1650.
Closes: #1963