-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config key for default maven repo and self check url #1899
Add config key for default maven repo and self check url #1899
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1899 +/- ##
==========================================
- Coverage 78.74% 78.72% -0.02%
==========================================
Files 131 131
Lines 2263 2266 +3
Branches 65 58 -7
==========================================
+ Hits 1782 1784 +2
- Misses 481 482 +1
Continue to review full report at Codecov.
|
I've two questions. Why would you want to override the URL for |
We have our own github enterprise running on-prem in an isolated network. The self check would just fail and timeout after a few seconds since github.com is not reachable. We only use sbt (which is why I haven't touched mill and I am not very familiar with it) and you can actually override the repositories that are used via If you are using coursier via cli you can also set the repository using args or as environment variable but we don't use coursier outside of sbt v1. To be honnest I wasn't sure what scala-steward was using the default maven repo for. There was a lot of trial and error befor it worked. For example, I had to build a new container and pre-build scalafmt in standalone mode as by default it would try to fetch some dependencies on the first run via coursier. |
Thanks for the explanation, @meier-christoph. I'm OK with merging this but could please change |
@fthomas thanks for the feedback, I made the changes as you suggested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @meier-christoph!
... instead of hardcoding Maven Central. If the default resolver is not overridden it, it will be Maven Central, so nothing will change in this case. I'm doing this for the same reason as given in #1899 where the hardcoded Maven Central was replaced in `SbtAlg` with the default resolver.
This PR adds a few additional arguments to cli and config for the default maven repo and the self check uri.
For a full offline run add :
We are using scala-steward in a closed environment with github enterprise and are currently running a fork of scala-steward v0.8, this is a cherry pick from our fork as we would like to switch over to the github apps variant asap