Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default resolver in MillAlg #3234

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Dec 6, 2023

... instead of hardcoding Maven Central. If the default resolver is not overridden it, it will be Maven Central, so nothing will change in this case.

I'm doing this for the same reason as given in #1899 where the hardcoded Maven Central was replaced in SbtAlg with the default resolver.

... instead of hardcoding Maven Central. If the default resolver is not
overridden it, it will be Maven Central, so nothing will change in this
case.

I'm doing this for the same reason as given in
#1899 where the
hardcoded Maven Central was replaced in `SbtAlg` with the default
resolver.
@fthomas fthomas added the enhancement New feature or request label Dec 6, 2023
@fthomas fthomas added this to the 0.29.0 milestone Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0dd0d80) 91.06% compared to head (bc21afe) 91.06%.

Files Patch % Lines
...org/scalasteward/core/buildtool/mill/MillAlg.scala 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3234      +/-   ##
==========================================
- Coverage   91.06%   91.06%   -0.01%     
==========================================
  Files         163      163              
  Lines        3391     3390       -1     
  Branches      308      304       -4     
==========================================
- Hits         3088     3087       -1     
  Misses        303      303              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fthomas fthomas merged commit 804f1cc into main Dec 8, 2023
8 of 10 checks passed
@fthomas fthomas deleted the topic/use-default-resolver-in-millalg branch December 8, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant