Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo specific post update hooks #2434

Merged

Conversation

987Nabil
Copy link
Contributor

@987Nabil 987Nabil commented Dec 26, 2021

Fixes #1997
fixes #2097

@codecov
Copy link

codecov bot commented Dec 26, 2021

Codecov Report

Merging #2434 (c27d532) into master (eb133cf) will increase coverage by 0.10%.
The diff coverage is 95.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2434      +/-   ##
==========================================
+ Coverage   80.93%   81.04%   +0.10%     
==========================================
  Files         141      142       +1     
  Lines        2439     2458      +19     
  Branches       53       41      -12     
==========================================
+ Hits         1974     1992      +18     
- Misses        465      466       +1     
Impacted Files Coverage Δ
...steward/core/repoconfig/PostUpdateHookConfig.scala 91.66% <91.66%> (ø)
...rg/scalasteward/core/edit/hooks/HookExecutor.scala 93.61% <100.00%> (+0.59%) ⬆️
.../org/scalasteward/core/repoconfig/RepoConfig.scala 100.00% <100.00%> (ø)
.../scala/org/scalasteward/core/application/Cli.scala 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb133cf...c27d532. Read the comment docs.

Copy link
Member

@mzuehlke mzuehlke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a small remark regarding logging

@987Nabil
Copy link
Contributor Author

987Nabil commented Dec 28, 2021

@mzuehlke I tried to put this changes on a branch in my fork and let this run. I put some settings into a file referenced via --repo-config, but even when defining a hook without a group/artifact id, the hook does not run. Do you have an idea why? Because I don't 🤷

@987Nabil
Copy link
Contributor Author

Ok, I guess I found it. The monoid def of RepoConfig was missing a combine of the hooks

@mzuehlke
Copy link
Member

Ok, I guess I found it. The monoid def of RepoConfig was missing a combine of the hooks

Good catch

@mzuehlke mzuehlke merged commit 9b1c09f into scala-steward-org:master Dec 28, 2021
@987Nabil 987Nabil deleted the repo-specific-post-update-hooks branch December 28, 2021 19:27
@fthomas fthomas added the enhancement New feature or request label Dec 31, 2021
@fthomas fthomas added this to the 0.14.0 milestone Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding Custom Plugin Behavior Feature request: run arbitrary (sbt) action after the update
3 participants