-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom PostUpdateHook
for sbt-typelevel
#2492
Add custom PostUpdateHook
for sbt-typelevel
#2492
Conversation
@@ -72,11 +72,14 @@ object HookExecutor { | |||
(GroupId("com.codecommit"), ArtifactId("sbt-spiewak-bintray")), | |||
(GroupId("io.github.nafg.mergify"), ArtifactId("sbt-mergify-github-actions")), | |||
(GroupId("io.chrisdavenport"), ArtifactId("sbt-davenverse")), | |||
(GroupId("org.http4s"), ArtifactId("sbt-http4s-org")), | |||
(GroupId("org.typelevel"), ArtifactId("sbt-typelevel")), | |||
(GroupId("org.typelevel"), ArtifactId("sbt-typelevel-ci-release")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sbt-typelevel-ci-release
is a lower-level plugin which only needs the sbt-github-actions post-update step.
Codecov Report
@@ Coverage Diff @@
## main #2492 +/- ##
==========================================
- Coverage 81.19% 81.14% -0.06%
==========================================
Files 142 142
Lines 2489 2498 +9
Branches 55 44 -11
==========================================
+ Hits 2021 2027 +6
- Misses 468 471 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
modules/core/src/main/scala/org/scalasteward/core/edit/hooks/HookExecutor.scala
Outdated
Show resolved
Hide resolved
@armanbilge In case you didn't know since #2434 Scala Steward can have repo specific post update hooks. |
@mzuehlke thanks, that config works well for single repositories but is difficult to maintain across orgs. For example, sbt-http4s-org extends sbt-typelevel and would like to add its own customized post-update hooks for all the repositories in http4s org. With these changes, all it needs to do is update the |
This adds a custom
PostUpdateHook
for sbt-typelevel, which calls atlPrePrBotHook
command alias. The idea is that:PostUpdateHook
to Steward.Additional background in:
tlPrePrBotHook
typelevel/sbt-typelevel#111.Let me know what you think. Thanks in advance! :)