Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repo-specific signoff option #3432

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

michaelmior
Copy link
Contributor

No description provided.

Copy link
Member

@mzuehlke mzuehlke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank. That looks really good.
I as you didn't saw a simpler way than passing this like you did.
I have just a tiny suggestion for improving the config code

@michaelmior
Copy link
Contributor Author

@mzuehlke Good call on that change! I amended my previous commit to include that.

Copy link
Member

@mzuehlke mzuehlke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@mzuehlke mzuehlke merged commit 432b78e into scala-steward-org:main Oct 13, 2024
5 checks passed
@michaelmior
Copy link
Contributor Author

@mzuehlke Thanks! Just wondering how often the public instance is updated. That is, when should I expect to be able to use this with one of my repos currently updated by @scala-steward?

@mzuehlke
Copy link
Member

In the past the public steward was always running the latest version. So it should already be live.
Please give it a try. sadly I don't have access to the logs as they are now operated by https://github.com/VirtusLab/scala-steward-repos/

@michaelmior
Copy link
Contributor Author

@mzuehlke Great! I'll give it a shot :)

@mzuehlke
Copy link
Member

@tgodzik am I right?

@tgodzik
Copy link
Contributor

tgodzik commented Oct 14, 2024

@tgodzik am I right?

IT fetches the latest image, so that should work depending on the steward schedule which I think runs twice a week.

@mzuehlke mzuehlke added the enhancement New feature or request label Oct 18, 2024
@mzuehlke mzuehlke added this to the 0.31.0 milestone Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants