Use RepoConfig#signoffCommits for migrations and hooks
#3576
+37
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses `RepoConfig#signoffCommits` for Scalafix migrations and post-update hooks commits and removes the `signoffCommits` fields from `PostUpdateHook` and `ScalafixMigration`. The latter fields concealed that `RepoConfig#signoffCommits` was partially ignored for post-update hooks and completely ignored for Scalafix migrations.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3576 +/- ##
==========================================
- Coverage 89.82% 89.80% -0.03%
==========================================
Files 174 174
Lines 5043 5031 -12
Branches 493 493
==========================================
- Hits 4530 4518 -12
Misses 513 513 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses
RepoConfig#signoffCommitsfor Scalafix migrations and post-update hooks commits and removes thesignoffCommitsfields fromPostUpdateHookandScalafixMigration(which were added in #3432). The latter fields concealed thatRepoConfig#signoffCommitswas partially ignored for post-update hooks and completely ignored for Scalafix migrations.