Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cats_v1_0_0 Scalafix migration #611

Merged
merged 2 commits into from
Jun 23, 2019
Merged

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Jun 22, 2019

No description provided.

@fthomas
Copy link
Member Author

fthomas commented Jun 22, 2019

This rule produced the following errors during my tests:

[info] [info] Set current project to scalafix-test (in build file:/home/frank/data/code/scala-steward/core/workspace/repos/fthomas/scalafix-test/)                                                                                      
[info] [error] (Compile / scalafix) scalafix.sbt.InvalidArgument: 7 errors
[info] [error] [E0] /tmp/scalafix508067038721054148/Cats_v1_0_0.scala16704897989312667318.scala:14:53 error: type mismatch;
[info] [error]  found   : List[Symbol]
[info] [error]  required: Seq[scalafix.v0.Symbol]
[info] [error]     Symbol("_root_.cats.syntax.CartesianOps.`|@|`.") ::
[info] [error]                                                      ^^^
[info] [error] 
[info] [error] [E1] /tmp/scalafix508067038721054148/Cats_v1_0_0.scala16704897989312667318.scala:143:10 error: type mismatch;
[info] [error]  found   : Symbol (in scala) 
[info] [error]  required: Symbol (in scalafix.v0) 
[info] [error]     Symbol("_root_.cats.data.EitherTFunctions.right.")
[info] [error]           ^
[info] [error] 
[info] [error] [E2] /tmp/scalafix508067038721054148/Cats_v1_0_0.scala16704897989312667318.scala:140:10 error: type mismatch;
[info] [error]  found   : Symbol (in scala) 
[info] [error]  required: Symbol (in scalafix.v0) 
[info] [error]     Symbol("_root_.cats.data.EitherTFunctions.left.")
[info] [error]           ^
[info] [error] 
[info] [error] [E3] /tmp/scalafix508067038721054148/Cats_v1_0_0.scala16704897989312667318.scala:82:55 error: type mismatch;
[info] [error]  found   : Symbol (in scala) 
[info] [error]  required: Symbol (in scalafix.v0) 
[info] [error]     val contraMatcher = SymbolMatcher.normalized(Symbol("_root_.cats.functor.Contravariant.Ops.`contramap`."))
[info] [error]                                                        ^
[info] [error] 
[info] [error] [E4] /tmp/scalafix508067038721054148/Cats_v1_0_0.scala16704897989312667318.scala:34:60 error: type mismatch;
[info] [error]  found   : Seq[Symbol]
[info] [error]  required: Seq[scalafix.v0.Symbol]
[info] [error]     SymbolMatcher.normalized(renames.keys.map(Symbol.apply).toSeq: _*)
[info] [error]                                                             ^
[info] [error] 
[info] [error] [E5] /tmp/scalafix508067038721054148/Cats_v1_0_0.scala16704897989312667318.scala:22:10 error: type mismatch;
[info] [error]  found   : Symbol (in scala) 
[info] [error]  required: Symbol (in scalafix.v0) 
[info] [error]     Symbol(s"_root_.cats.syntax.CartesianOps.`<*`.")
[info] [error]           ^
[info] [error] 
[info] [error] [E6] /tmp/scalafix508067038721054148/Cats_v1_0_0.scala16704897989312667318.scala:21:10 error: type mismatch;
[info] [error]  found   : Symbol (in scala) 
[info] [error]  required: Symbol (in scalafix.v0) 
[info] [error]     Symbol(s"_root_.cats.syntax.CartesianOps.`*>`."),
[info] [error]           ^

I assume that the Scalafix version Scala Steward is using is incompatible with the Scalafix version Cats_v1_0_0 was written for.

@codecov
Copy link

codecov bot commented Jun 22, 2019

Codecov Report

Merging #611 into master will increase coverage by 0.34%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #611      +/-   ##
==========================================
+ Coverage   59.77%   60.11%   +0.34%     
==========================================
  Files          67       67              
  Lines         870      875       +5     
  Branches       27       23       -4     
==========================================
+ Hits          520      526       +6     
+ Misses        350      349       -1
Impacted Files Coverage Δ
...scala/org/scalasteward/core/scalafix/package.scala 100% <100%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 662b79f...a3a1d98. Read the comment docs.

@fthomas
Copy link
Member Author

fthomas commented Jun 23, 2019

@fthomas fthomas merged commit a7a5a57 into master Jun 23, 2019
@fthomas fthomas added the enhancement New feature or request label Jun 23, 2019
@fthomas fthomas added this to the 0.3.0 milestone Jun 23, 2019
@fthomas fthomas deleted the topic/Cats_v1_0_0_migration branch June 23, 2019 11:50
@fthomas fthomas added scalafix-migration and removed enhancement New feature or request labels Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant