-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sbt-scalafix to 0.9.5 #2907
Conversation
In Scalafix v0.9 there is a
will need to be written against the new symbol format
|
Scalafix 0.6.x only supports outdated Scala versions so it's not much value today. The 0.9.x API will probably stay stable for a long time, it should probably be released as v1.0. |
Codecov Report
@@ Coverage Diff @@
## master #2907 +/- ##
=======================================
Coverage 94.26% 94.26%
=======================================
Files 363 363
Lines 6945 6945
Branches 181 181
=======================================
Hits 6547 6547
Misses 398 398 Continue to review full report at Codecov.
|
Rewriting the symbol matchers did the trick. Thanks, @olafurpg! sbt-scalafix is now on 0.9.5. |
And it works for Scala Steward: https://github.com/fthomas/scalafix-test/pull/9/files :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much!
This updates Scalafix to 0.6.0-M9 by applying this diff. I've checked locally that the Scalafix tests still pass.
My ultimate goal is to update Scalafix to 0.9.x so that this rule (and potential future rules) can be used by Scala Steward (scala-steward-org/scala-steward#611) but it is currently unclear to me if updating to 0.9.x means that this rule needs to rewritten with Scalafix'
v1
API. @olafurpg dov0
rules also work with 0.9.x?