-
Notifications
You must be signed in to change notification settings - Fork 1k
Rewrote implicits section of the tour #746 #1003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I have few questions about this change. |
I've answered your question at https://contributors.scala-lang.org/t/multi-language-files/1519 |
…into fix746 Merge fix for 746
it looks like #1018 will be merged first and you'll need to rebase. |
#1018 has been merged. |
I was going to fold changes to http://docs.scala-lang.org/tutorials/FAQ/finding-implicits.html on top of this PR, but I'm not sure this is a good foundation. I doubt whether the examples are explanatory. I also think it's useful to have two pages for params and conversions. For params, we need an easy typeclass example that is meaningful. I see the current page links to that faq page; so my task is to inline it. However, I'll do that from head. |
To clarify things more, now that #1018 changes are in master, and as part of this PR I removed implicit-parameters.md, so now I would manually need to take new content from implicit-parameters.md and put them in implicit.md(implicit-parmeters.md is still deleted). |
Can anyone please confirm my last comment? |
Apologies for the delay. The situation here seems confused and confusing, so probably everyone is (like me) hesitating to comment because it's hard to even understand what's going on. In particular, I've lost track of what the benefit is supposed to be of merging the two sections into one...? Is there even a consensus on making that change, or was it just an idea Travis had? It doesn't seem like a clear improvement to me. I'm not strongly against, either... I just don't get it. Maybe the benefit just needs to be explained to me. I'm not sure what other improvements might remain to be incorporated. |
I think it would be better if we close this PR.Instead, I would prefer to first really understand what latest changes in implicit-parameters.md bring to table,and then if merging of implicit files into one still makes sense, we can go further. |
@mghildiy okay — thanks for working on this, sorry about the overlap in work that ended up happening |
No description provided.