Implicits tour draft #1019
Closed
Implicits tour draft #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@siddhartha-gadgil glad you found your way to this repo. a lot has changed here since @travissarles did his work, the whole site was redone. it looks like you inadvertently pulled in some changes that are unrelated to your edits. |
|
I'll redo what remains relevant.
Regards
Siddhartha
…On Fri 16 Feb, 2018, 4:41 AM Seth Tisue, ***@***.***> wrote:
#1018 <#1018> is merged now,
but this might also overlap with #1003
<#1003>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1019 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADatpBoyn5hMxLenh14zQMIfLsQNkKBZks5tVLmTgaJpZM4SGnmq>
.
|
|
Seems redundant given rewriting that is already merged. |
|
sorry about what turned out to be redundant efforts — thanks for taking the time on it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have attempted to address the reviewers comments, including
some rewriting,
a section on implicit classes,
new examples.
I have also added a section with a very basic case of typeclasses.