modify/correct _zh-cn/index.md #2394
Conversation
according to review. Add _zh-cn/scala3/reference/README.md Add _zh-cn/overview/scala3-book/why-scala-3.md
|
@benluo First of all, thank you for your work, it would be better if you could create new pull request. Because big PR isn't easy to be reviewed. |
|
I don't know how to split my pull request. Any way, I will wait to commit my git until you review and merge all translation to main branch. |
|
Hi, @benluo I see the some comments is closed, please resolve it or give a reasonable explanation. @liufengyun It's almost done, so please take a look. |
|
@jxnu-liguobin I modified translation according to all your comments in my latest commit. So i closed your comments without feedback. Please check my latest commit (300d5cd. |
sry. It was my misreading. |
Co-authored-by: 梦境迷离 <568845948@qq.com>
Co-authored-by: 梦境迷离 <568845948@qq.com>
Co-authored-by: 梦境迷离 <568845948@qq.com>
Co-authored-by: 梦境迷离 <568845948@qq.com>
Co-authored-by: 梦境迷离 <568845948@qq.com>
|
I don't have 《Scala编程第5版》. Do you want to use all terms translation from that book? |
Co-authored-by: 梦境迷离 <568845948@qq.com>
|
Hi @SethTisue, Since this PR is really too huge (I'm not looking at it very carefully), do we need to split it into multiple smaller ones? or merge it first and then wait for other volunteers to modify it subsequently. |
|
Our usual approach with translations is to merge something even if it isn't perfect, and figure it can always be improved later. The CI failure needs attention, though? |
corrected. |
|
this also looks like #2510, which should come first? |
Yes, I think this pr should be merged at first. |
|
thank you @benluo and @jxnu-liguobin ! |
modify/correct some translation in _zh-cn/index.md according to latest English version.