Why scala 3 tabs code #2510
Merged
Why scala 3 tabs code #2510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishabosha
reviewed
Sep 13, 2022
|
Im not so sure about adding translations until the book is stable, which could be another few months from now. i.e. the content might change a lot in the English version. What do you think? |
This was referenced Sep 13, 2022
|
@jxnu-liguobin there are many files changed in this PR that don't match just the "why scala 3" page, is that intentional? |
In fact, I don't know why this PR is exists. The new commits seem for other issues. Because this PR is based on a PR that has not yet been merged. |
|
needs rebase now that #2394 is merged |
Co-authored-by: Jamie Thompson <bishbashboshjt@gmail.com>
bishabosha
force-pushed
the
why-scala-3-tabs-code
branch
from
b9a643e to
1360cae
Compare
|
I just did the rebase - I see now it really is just adding code tabs, so ill review |
bishabosha
reviewed
Sep 15, 2022
bishabosha
reviewed
Sep 15, 2022
bishabosha
reviewed
Sep 15, 2022
bishabosha
reviewed
Sep 15, 2022
bishabosha
reviewed
Sep 15, 2022
Co-authored-by: Jamie Thompson <bishbashboshjt@gmail.com>
Co-authored-by: Jamie Thompson <bishbashboshjt@gmail.com>
Co-authored-by: Jamie Thompson <bishbashboshjt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add tabs for code