Skip to content

Non-bootstrapped serialization tests are failing since scala/scala#7297 #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SethTisue opened this issue Oct 24, 2018 · 9 comments
Closed

Comments

@SethTisue
Copy link
Member

SethTisue commented Oct 24, 2018

reported by @milessabin on Gitter

@szeiger:

Non-bootstrapped serialization tests are failing since scala/scala#7297. We need to re-starr to fix that

references scala/scala#7297 and #562

@SethTisue
Copy link
Member Author

@retronym:

Oh, I think I know what you mean. The serialization tests under junit/test only work after a round of bootstrapping.
Arguably they should be partest-s to avoid that problem.
But a re-STARR is fine with me.

@milessabin
Copy link

Except that there are partests failing as well ...

@SethTisue
Copy link
Member Author

@dwijnand it would be helpful to have your proposed Rosetta Stone of what is compiled with what and runs with what, here

@retronym
Copy link
Member

My comment was wrong, the distinction between JUnit and partest --run would only matter if testing serialization of modules defined in the test case. These failures are occuring in modules defined in src/library, which is compiled with STARR regardless of the test frameworks. CI tests always re-starr on HEAD before running tests (aka "do a fully bootstrapped build").

@milessabin
Copy link

Is there anything stopping us re-starring now?

@lrytz
Copy link
Member

lrytz commented Oct 26, 2018

We just need to publish a release to maven (or not?)

@milessabin
Copy link

Is there anything I can do to help with this ... I like to have testAll complete successfully locally before PRing, and it failing makes me anxious 🙀

@retronym
Copy link
Member

We need to trigger a release build to Maven Central for a recent SHA, and then submit a PR to use that in version.properties.

The workaround is to locally use:

sbt ';setupPublishCore;publishLocal;generateBuildCharacterPropertiesFile' && sbt -Dstarr.version=$(cat buildcharacter.properties |  grep '^maven.version.number=' | cut -d '=' -f 2) testAll

@SethTisue
Copy link
Member Author

re-STARR PR from @hrhino scala/scala#7430

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants