Use proxy-based serialization for modules #7297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 1, 2018
|
Should this be marked [nomerge] as we cant apply this to 2.12 because of serialisation binary compat |
|
As we are asserting that this work well with a SecurityManager, with minimal permissions (i.e. Scala.* has reflect access), there should be a test for that |
szeiger
approved these changes
Oct 8, 2018
src/compiler/scala/tools/nsc/typechecker/SyntheticMethods.scala
Outdated
Show resolved
Hide resolved
|
I'll rebase and improve the comment. |
retronym
force-pushed
the
review/6877
branch
2 times, most recently
from
8976c9b to
f3f9ab5
Compare
This avoids serializing any state of serializable singletons which would be discarded anyway after deserializing (SI-10412). Use ClassValue to cache instances, which is significantly faster for subsequent deserialization of a given module. ClassValue entries only weakly reference the key and value so the class can be unloaded. Wrap use of reflection in AccessControler to play nicely under SecurityManager. A security manager will only walk up the stack to this point to check permissions, so if users grant scala-library permissions in the policy, the call will be allowed regardless of the code higher in the stack that has triggered deserialization.
I can't really figure out how to (or maybe, muster the energy to) rig up a test for this. I think it would require me to run a forked JVM with a security manager and a setting for
That's only required for changes committed to 2.12.x that shouldn't/needn't be merged forward to 2.13.x. |
|
@retronym I don't think that it is as complex as that for the test. I will pop one in a separate new PR great to see this merged 😄 |
smarter
pushed a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 22, 2019
In scala#4450 and Scala 2.12, readResolve is used to make sure deserializing object returns the singleton instance of the object, but this doesn't prevent the fields of the objects from being serializable in the first place even though they're not used. Scala 2.13 switched to using writeReplace to completely bypass serialization of the object in scala/scala#7297. This commit adapts this to Dotty. Co-Authored-By: Ingar Abrahamsen <ingar@abrahams1.com> Co-Authored-By: Jason Zaugg <jzaugg@gmail.com>
This was referenced Jan 22, 2019
smarter
pushed a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 22, 2019
In scala#4450 and Scala 2.12, readResolve is used to make sure deserializing an object returns the singleton instance of the object, but this doesn't prevent the fields of the objects from being serialized in the first place even though they're not used. Scala 2.13 switched to using writeReplace to completely bypass serialization of the object in scala/scala#7297. This commit adapts this to Dotty. Co-Authored-By: Ingar Abrahamsen <ingar@abrahams1.com> Co-Authored-By: Jason Zaugg <jzaugg@gmail.com>
smarter
pushed a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 22, 2019
In scala#4450 and Scala 2.12, readResolve is used to make sure deserializing an object returns the singleton instance of the object, but this doesn't prevent the fields of the objects from being serialized in the first place even though they're not used. Scala 2.13 switched to using writeReplace to completely bypass serialization of the object in scala/scala#7297. This commit adapts this to Dotty. Co-Authored-By: Ingar Abrahamsen <ingar@abrahams1.com> Co-Authored-By: Jason Zaugg <jzaugg@gmail.com>
smarter
pushed a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 22, 2019
In scala#4450 and Scala 2.12, readResolve is used to make sure deserializing an object returns the singleton instance of the object, but this doesn't prevent the fields of the objects from being serialized in the first place even though they're not used. Scala 2.13 switched to using writeReplace to completely bypass serialization of the object in scala/scala#7297. This commit adapts this to Dotty. Co-Authored-By: Ingar Abrahamsen <ingar@abrahams1.com> Co-Authored-By: Jason Zaugg <jzaugg@gmail.com>
smarter
pushed a commit
to smarter/dotty
that referenced
this pull request
Jan 25, 2019
In scala#4450 and Scala 2.12, readResolve is used to make sure deserializing an object returns the singleton instance of the object, but this doesn't prevent the fields of the objects from being serialized in the first place even though they're not used. Scala 2.13 switched to using writeReplace to completely bypass serialization of the object in scala/scala#7297. This commit adapts this to Dotty. Co-Authored-By: Ingar Abrahamsen <ingar@abrahams1.com> Co-Authored-By: Jason Zaugg <jzaugg@gmail.com>
smarter
pushed a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 25, 2019
In scala#4450 and Scala 2.12, readResolve is used to make sure deserializing an object returns the singleton instance of the object, but this doesn't prevent the fields of the objects from being serialized in the first place even though they're not used. Scala 2.13 switched to using writeReplace to completely bypass serialization of the object in scala/scala#7297. This commit adapts this to Dotty. Co-Authored-By: Ingar Abrahamsen <ingar@abrahams1.com> Co-Authored-By: Jason Zaugg <jzaugg@gmail.com>
smarter
pushed a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 25, 2019
In scala#4450 and Scala 2.12, readResolve is used to make sure deserializing an object returns the singleton instance of the object, but this doesn't prevent the fields of the objects from being serialized in the first place even though they're not used. Scala 2.13 switched to using writeReplace to completely bypass serialization of the object in scala/scala#7297. This commit adapts this to Dotty. Co-Authored-By: Ingar Abrahamsen <ingar@abrahams1.com> Co-Authored-By: Jason Zaugg <jzaugg@gmail.com>
smarter
pushed a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 25, 2019
In scala#4450 and Scala 2.12, readResolve is used to make sure deserializing an object returns the singleton instance of the object, but this doesn't prevent the fields of the objects from being serialized in the first place even though they're not used. Scala 2.13 switched to using writeReplace to completely bypass serialization of the object in scala/scala#7297. This commit adapts this to Dotty. Co-Authored-By: Ingar Abrahamsen <ingar@abrahams1.com> Co-Authored-By: Jason Zaugg <jzaugg@gmail.com>
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 25, 2019
In scala#4450 and Scala 2.12, readResolve is used to make sure deserializing an object returns the singleton instance of the object, but this doesn't prevent the fields of the objects from being serialized in the first place even though they're not used. Scala 2.13 switched to using writeReplace to completely bypass serialization of the object in scala/scala#7297. This commit adapts this to Dotty. Co-Authored-By: Ingar Abrahamsen <ingar@abrahams1.com> Co-Authored-By: Jason Zaugg <jzaugg@gmail.com>
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 26, 2019
In scala#4450 and Scala 2.12, readResolve is used to make sure deserializing an object returns the singleton instance of the object, but this doesn't prevent the fields of the objects from being serialized in the first place even though they're not used. Scala 2.13 switched to using writeReplace to completely bypass serialization of the object in scala/scala#7297. This commit adapts this to Dotty. Co-Authored-By: Ingar Abrahamsen <ingar@abrahams1.com> Co-Authored-By: Jason Zaugg <jzaugg@gmail.com>
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Feb 2, 2019
In scala#4450 and Scala 2.12, readResolve is used to make sure deserializing an object returns the singleton instance of the object, but this doesn't prevent the fields of the objects from being serialized in the first place even though they're not used. Scala 2.13 switched to using writeReplace to completely bypass serialization of the object in scala/scala#7297. This commit adapts this to Dotty. Co-Authored-By: Ingar Abrahamsen <ingar@abrahams1.com> Co-Authored-By: Jason Zaugg <jzaugg@gmail.com>
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Feb 2, 2019
In scala#4450 and Scala 2.12, readResolve is used to make sure deserializing an object returns the singleton instance of the object, but this doesn't prevent the fields of the objects from being serialized in the first place even though they're not used. Scala 2.13 switched to using writeReplace to completely bypass serialization of the object in scala/scala#7297. This commit adapts this to Dotty. Co-Authored-By: Ingar Abrahamsen <ingar@abrahams1.com> Co-Authored-By: Jason Zaugg <jzaugg@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids serializing any state of serializable singletons which
would be discarded anyway after deserializing (SI-10412).
Use ClassValue to cache instances, which is significantly faster for
subsequent deserialization of a given module. ClassValue entries only
weakly reference the key and value so the class can be unloaded.
Wrap use of reflection in AccessControler to play nicely under
SecurityManager. A security manager will only walk up the stack
to this point to check permissions, so if users grant scala-library
permissions in the policy, the call will be allowed regardless of
the code higher in the stack that has triggered deserialization.
(Rebase and extension of #6877)
Fixes scala/bug#10412