Implemented DesktopPane and InternalFrame

[reggert]

This feature adds support for JDesktopPane and JInternalFrame, as well as the latter's event hierarchy, to resolve #119 .

I branched directly off the v2.1.1 tag to allow it to be applied as a patch for the latest release. I can rebase onto work if necessary, though, but there should be no conflicts either way.

I tried to follow the conventions used by Window/RichWindow/Frame as much as possible, and avoided implementing wrappers for any parts of the Swing API that were documented as not intended for use by applications. It's possible that I may have neglected to implement some obscure feature, but I think I've covered all the likely use cases.

I originally implemented this within and tested it with a separate project that I am working on, and everything I tried out seems to be working.

Note that JInternalFrame does not extend the AWT Window class, so there was no way (that I could see) to integrate InternalFrame directly into the Window/RichWindow hierarchy.

[Sciss]

Thank you! I will only be able to review this in the first week of June. If someone else wants to go ahead, please do so. Please remind me if I don't follow up on this.

[reggert]

Anyone had a chance to look at this yet?

[benhutchison]

Hi Richard, rest assured I want to ensure your contribution makes it into ScalaSwing. I'd like to wait for @Sciss to review as (unlike myself) he's an active ScalaSwing user and will likely do a better review. He said early June so let's give him some time. But if that doesn't happen I'll ensure it gets merged.

…

On Thu, Jun 4, 2020 at 4:38 AM Richard W. Eggert II < ***@***.***> wrote: Anyone had a chance to look at this yet? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#120 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAXJZEWDIOQHBU2OUP4AZLRU2KA7ANCNFSM4M3QANBA> .

[Sciss]

Thanks for your contribution, and for your patience. I had a brief look, in general it looks good. Of course one question would be if there is a common interface to Frame and InternalFrame, which could fix a design mistake (IMO) in Java Swing; but this could be also added at a later point.

The DragMode style is a bit different than the rest of Scala Swing when it comes to wrapping constants. I think it should be an Enumeration like everywhere else (e.g. FileChooser.Result, FileChooser.SelectionMode, BorderPanel.Position, Alignment, etc.)

Apart from this change, I would be happy to merge. If a second pair of eyes is available, it would be great, but at least from cursory examination, I cannot see any issues.

[Sciss]

Another question is if you have already signed the CLA? (See #51 (comment)). To avoid future problems, we require this from any first time contributor.

[reggert]

CLA signed.

[reggert]

I've converted DragMode to an Enumeration and added some documentation for it.

[reggert]

Last (force) push was just tweaks to the wording of the DragMode documentation.