Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmdTests are not executed on test #14428

Closed
nicolasstucki opened this issue Feb 7, 2022 · 0 comments · Fixed by #14427
Closed

cmdTests are not executed on test #14428

nicolasstucki opened this issue Feb 7, 2022 · 0 comments · Fixed by #14427
Assignees
@nicolasstucki
Labels
area:infrastructure itype:bug
Milestone
3.1.3

Comments

@nicolasstucki
Copy link
Contributor

For some reason, these tests are only running on test_non_bootstrapped which is not even run on the PRs. We need to re-enable these tests.

This lead to the failure in #14416
@nicolasstucki nicolasstucki mentioned this issue Feb 7, 2022
Merged
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Feb 7, 2022
@nicolasstucki
Re-enable missing cmdTests
20e7269 
It might have been disabled by mistake because bootstrapCmdTests was
assumed to be the set of tests for the bootstrapped compiler.
The second is an extension for the second with tests that can only
be run on the bootstrapped compiler. It is now renamed to
bootstrappedOnlyCmdTests to make sure we avoid this potential confusion.

Fixes scala#14428
@nicolasstucki nicolasstucki mentioned this issue Feb 8, 2022
Closed
olsdavis pushed a commit to olsdavis/dotty that referenced this issue Apr 4, 2022
@nicolasstucki @olsdavis
Re-enable missing cmdTests
03abded 
It might have been disabled by mistake because bootstrapCmdTests was
assumed to be the set of tests for the bootstrapped compiler.
The second is an extension for the second with tests that can only
be run on the bootstrapped compiler. It is now renamed to
bootstrappedOnlyCmdTests to make sure we avoid this potential confusion.

Fixes scala#14428
@Kordyjan Kordyjan added this to the 3.1.3 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolasstucki nicolasstucki

Labels
area:infrastructure itype:bug
Projects
None yet
Milestone
3.1.3
Development

Successfully merging a pull request may close this issue.

Show inlined positions with source code dotty-staging/dotty
2 participants
@nicolasstucki @Kordyjan