Show inlined positions with source code #14427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
reenable-inline-positions
branch
from
4064765
to
f9a2a0a
Compare
It might have been disabled by mistake because bootstrapCmdTests was assumed to be the set of tests for the bootstrapped compiler. The second is an extension for the second with tests that can only be run on the bootstrapped compiler. It is now renamed to bootstrappedOnlyCmdTests to make sure we avoid this potential confusion. Fixes scala#14428
nicolasstucki
force-pushed
the
reenable-inline-positions
branch
from
f9a2a0a
to
20e7269
Compare
|
I'm just curious. Is this further work needed to resolve #13991? |
|
@deusaquilus the fix to #13991 had to be reverted because it broke the CI (cf #14406), this PR re-enables it. |
smarter
approved these changes
Feb 8, 2022
| @@ -56,6 +56,7 @@ cp tests/neg/i6371/B_2.scala $OUT/B.scala | |||
| "$SBT" "scalac $OUT/A.scala -d $OUT1" | |||
| rm $OUT/A.scala | |||
| "$SBT" "scalac -classpath $OUT1 -d $OUT1 $OUT/B.scala" > "$tmp" 2>&1 || echo "ok" | |||
| cat "$tmp" # for debugging | |||
There was a problem hiding this comment.
Could you comment that out or only display it in case the test doesn't pass? Otherwise we get some error output in the CI that could be misinterpreted as a test failure.
There was a problem hiding this comment.
Commented out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enable #14002. Fix issue when inlined position sources are not available.
Fixes #13991
Also fixes #14428