Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calm param autotupling for overloads #21552

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Calm param autotupling for overloads #21552

merged 1 commit into from
Sep 23, 2024

Conversation

dwijnand
Copy link
Member

@dwijnand dwijnand commented Sep 6, 2024

When resolving method overloads, we look to apply the same parameter
auto-tupling logic that we have in typedFunctionValue. But we only
checked the function was unary without checking whether it was a tuple.
So I reused the same precondition.

Fixes #16108

When resolving method overloads, we look to apply the same parameter
auto-tupling logic that we have in typedFunctionValue.  But we only
checked the function was unary without checking whether it was a tuple.
So I reused the same precondition.
@dwijnand dwijnand marked this pull request as ready for review September 10, 2024 09:41
@dwijnand dwijnand requested a review from odersky September 10, 2024 09:41
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@odersky odersky merged commit e5f7272 into scala:main Sep 23, 2024
28 checks passed
@dwijnand dwijnand deleted the functoid branch September 23, 2024 20:56
@WojciechMazur WojciechMazur added this to the 3.6.0 milestone Oct 8, 2024
@prolativ
Copy link
Contributor

Backport into LTS waiting for the fix in #21741

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants