Allow autotupling if fn's param is a type param #21741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
reviewed
Nov 4, 2024
| formals.length == 1 && ptIsCorrectProduct(formals.head, args) | ||
| formals.lengthIs == 1 && { | ||
| ptIsCorrectProduct(formals.head, args) | ||
| | formals.head.dealias.isInstanceOf[TypeParamRef] // eg. i21682 |
There was a problem hiding this comment.
I think we need an explanation what goes on here and why the test is necessary and sufficient. Right now I have no idea what goes on here.
dwijnand
force-pushed
the
21682-reg-infr-overload-dataprism
branch
from
d93cc60 to
9d2aeac
Compare
dwijnand
commented
Nov 6, 2024
| // See i21682 for an example. | ||
| val tup = defn.tupleType(args.map(v => if v.tpt.isEmpty then WildcardType else typedAheadType(v.tpt).tpe)) | ||
| val TypeBounds(lo, hi) = formal.paramInfo | ||
| lo <:< tup && tup <:< hi |
There was a problem hiding this comment.
Btw, I experimented pushing this change into ptIsCorrectProduct and extending it to TypeVar. That way, given that ptIsCorrectProduct is already used by typedFunctionValue, we would allow code like this, from tests/neg/function-arity.scala, to compile:
def unary[T](x: T => Unit) = ???
unary((x, y) => ()) // errorAre we interested in that working?
odersky
approved these changes
Nov 13, 2024
WojciechMazur
added
the
backport:nominated
WojciechMazur
added
backport:accepted
WojciechMazur
added
backport:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21682