Fix #22794: Emit the definition of Arrays.newArray even though it's a primitive.
#22797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it's a primitive. Until 3.6.x, we used the user-space definition of `Arrays.newArray` in Scala.js. We changed it to a primitve in 2852168, to match the behavior of the JVM backend. However, that had the side effect of not emitting its definition at all, like other primitives. For backward binary compat reasons, we do need that definition. We specifically make an exception for that method, which is now emitted, even though it is otherwise treated as a primitive.
sjrd
added
the
backport:accepted
sjrd
changed the title
Arrays.newArray even though it's…Arrays.newArray even though it's a primitive.
tgodzik
approved these changes
Mar 13, 2025
|
/cc @WojciechMazur to backport to the 3.7.0 release branch. It fixes a critical regression that makes Scala.js basically unusable in 3.7.0-RC1. |
WojciechMazur
added
backport:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until 3.6.x, we used the user-space definition of
Arrays.newArrayin Scala.js. We changed it to a primitve in2852168, to match the behavior of the JVM backend.
However, that had the side effect of not emitting its definition at all, like other primitives. For backward binary compat reasons, we do need that definition.
We specifically make an exception for that method, which is now emitted, even though it is otherwise treated as a primitive.
Needs to be backported to the 3.7.0-x branch.