Scala.js: Emit js.NewArray IR nodes when possible.
#22446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although there is a *correct* implementation of `sr.Arrays.newArray`, it is not efficient when creating 1-dimensional arrays. The JVM backend special-cases it to emit `newarray` bytecode instructions. We now also special-case it in the JS backend. In the Scala.js IR however, `js.NewArray` only accepts a single dimension. For multiple dimensions, the right thing to do is to emit a direct call to `jlr.Array.newInstance`.
smarter
approved these changes
Jan 27, 2025
|
Does make sense backporting it to LTS, which doesn't update the Scala JS versions? |
|
Probably. The LTS uses an older version of Scala.js that had builtin support for If you backport this one, you also need to backport #22797 . |
This was referenced Apr 3, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although there is a correct implementation of
sr.Arrays.newArray, it is not efficient when creating 1-dimensional arrays. The JVM backend special-cases it to emitnewarraybytecode instructions.We now also special-case it in the JS backend. In the Scala.js IR however,
js.NewArrayonly accepts a single dimension. For multiple dimensions, the right thing to do is to emit a direct call tojlr.Array.newInstance.