Fix #3304: Launch script now requires Java 8 #3307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
approved these changes
Oct 11, 2017
dist/bin/common
Outdated
| JAVA_VERSION=$("$JAVACMD" -Xmx512M -version 2>&1 | grep ' version "' | sed 's/.*version "\([0-9]*\)\(\.[0-9]*\)\{0,1\}\(.*\)*"/\1\2/; 1q') | ||
|
|
||
| if [ "$JAVA_VERSION" != "1.8" ] ; then | ||
| echo "Error: Java 8 is required, actual $JAVA_VERSION" |
There was a problem hiding this comment.
I think it'd be nice if the message explained that a different version of Java could be set by using the JAVA_HOME environment variable.
liufengyun
approved these changes
Oct 12, 2017
liufengyun
reviewed
Oct 12, 2017
dist/bin/common
Outdated
| @@ -61,6 +61,14 @@ if [ ! -x "$JAVACMD" ] ; then | |||
| exit 1 | |||
| fi | |||
|
|
|||
| # parses 1.7, 1.8, 9, etc out of java version "1.8.0_91" | |||
| JAVA_VERSION=$("$JAVACMD" -Xmx512M -version 2>&1 | grep ' version "' | sed 's/.*version "\([0-9]*\)\(\.[0-9]*\)\{0,1\}\(.*\)*"/\1\2/; 1q') | |||
There was a problem hiding this comment.
A minor note: why -Xmx512M, it seems it's not necessary. But to be safer, let's just keep it as it is.
There was a problem hiding this comment.
There was a problem hiding this comment.
But I suppose it is not needed here
allanrenucci
force-pushed
the
fix-#3304
branch
from
80ac419 to
a67441a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.