Stop rewriting withFilter to filter #4602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was dropped for Scala 2 in scala/scala#5252 for 2.12.0-RC1, as discussed for instance in scala/bug#6455 and scala/bug#8339. Beyond this code, also remove `MaybeFilter` attachment and attending code introduced in fcea3d5. A caveat is that, unexpectedly, this code was added in 2016-08-24, after scala/scala#5252 was merged, as if the decision was reversed; but scala#1461 says: > Also, I went through tests in pending/pos and reclassified as far as possible. So I assume this just happened because the Scala 2 PR didn't remove our pending test.
Blaisorblade
force-pushed
the
drop-withFilter-filter-rewrite
branch
from
b2b7a4f to
7b9853a
Compare
|
Also related: #2573 It would be great of we could drop |
allanrenucci
approved these changes
May 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was dropped for Scala 2 in scala/scala#5252 for 2.12.0-RC1, as discussed for instance in scala/bug#6455 and scala/bug#8339.
Beyond this code, also remove
MaybeFilterattachment and attending codeintroduced in fcea3d5.
A caveat is that, unexpectedly, this code was added in 2016-08-24, after
scala/scala#5252 was merged, as if the decision was reversed; but #1461 says:
So I assume this just happened because the Scala 2 PR (of course) didn't remove our pending test.