Flatten the tasty.Reflection cake #8138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the cake pattern made it easy to split and keep into smaller files. But this comes at a cost: * Extra bridges * Not knowing where to find stuff * Hard to update * Inability to use opaque types and proper extension methods The downside is that we will have a larger `Reflection.scala` file, but it will be proportional to the size of `CompilerInterface.scala` which has been easier to manage than the cake. Note: `scala.tasty.Reflection` did not have any API changes.
This was referenced Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the cake pattern made it easy to split and keep into smaller files.
But this comes at a cost:
The downside is that we will have a larger
Reflection.scalafile, butit will be proportional to the size of
CompilerInterface.scalawhich hasbeen easier to manage than the cake.
Note:
scala.tasty.Reflectiondid not have any API changes.