Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove implicits from tasty reflection #8142

Merged
merged 3 commits into from
Jan 31, 2020
Merged

Remove implicits from tasty reflection #8142

merged 3 commits into from
Jan 31, 2020

Conversation

nicolasstucki
Copy link
Contributor

Based on #8138

@nicolasstucki nicolasstucki self-assigned this Jan 30, 2020
@nicolasstucki nicolasstucki force-pushed the remove-implicits-from-tasty-reflection branch from 7e1b8e5 to e8206d7 Compare January 30, 2020 16:20
@nicolasstucki nicolasstucki marked this pull request as ready for review January 30, 2020 18:14
liufengyun
liufengyun approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM

library/src/scala/tasty/Reflection.scala Show resolved Hide resolved
library/src/scala/tasty/Reflection.scala Outdated Show resolved Hide resolved
library/src/scala/tasty/Reflection.scala Outdated Show resolved Hide resolved
@nicolasstucki nicolasstucki merged commit b1c9a28 into scala:master Jan 31, 2020
@nicolasstucki nicolasstucki deleted the remove-implicits-from-tasty-reflection branch January 31, 2020 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasstucki @liufengyun