-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release info for publishing to Maven Central #246
Conversation
Alright, so you'll need to rebase after I merged in the original one. Also, one more thing. The |
@ckipp01 Rebase done. |
build.sbt
Outdated
@@ -9,6 +11,12 @@ lazy val `course-management-tools` = | |||
.aggregate(cmta, cmtc, core, `functional-tests`, docs) | |||
.settings(commonSettings: _*) | |||
.settings(publish / skip := true) | |||
.settings(inThisBuild(List( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sort of a total nit, but if you're using inThisBuild
it doesn't actually need to be nested in here. It can live at the top level and also work fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense; redundant stuff shouldn't be present. Removing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, the change you made isn't the same. So you'll notice now that your settings are only applying to the aggregate, not all projects. So for example if you would look at the developers set for cmta
you'll see there is none. So you'd need to either use inThisBuild
at the top level, or move the settings themselves into your commonSettings
which then are given to each module.
No description provided.