Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add release info for publishing to Maven Central #246

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Add release info for publishing to Maven Central #246

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c45fe96
Add release info for publishing to Maven Central
eloots Jul 25, 2023
4de62d4
Remove redundant stuff
eloots Jul 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
import Build._
import Build.*

import scala.collection.Seq

ThisBuild / dynverVTagPrefix := false
ThisBuild / sonatypeCredentialHost := "s01.oss.sonatype.org"
Expand All @@ -9,6 +11,12 @@ lazy val `course-management-tools` =
.aggregate(cmta, cmtc, core, `functional-tests`, docs)
.settings(commonSettings: _*)
.settings(publish / skip := true)
.settings(inThisBuild(List(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sort of a total nit, but if you're using inThisBuild it doesn't actually need to be nested in here. It can live at the top level and also work fine.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense; redundant stuff shouldn't be present. Removing it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the change you made isn't the same. So you'll notice now that your settings are only applying to the aggregate, not all projects. So for example if you would look at the developers set for cmta you'll see there is none. So you'd need to either use inThisBuild at the top level, or move the settings themselves into your commonSettings which then are given to each module.

organization := "com.lunatech",
homepage := Some(url("https://cmt.lunatech.com/")),
developers := List(
Developer("eloots", "Eric Loots", "eric.loots@lunatech.com", url("https://github.com/eloots"))),
licenses := Seq("Apache-2.0" -> url("http://www.apache.org/license/LICENSE-2.0")))))

lazy val core =
project.in(file("core")).settings(commonSettings: _*).settings(libraryDependencies ++= Dependencies.coreDependencies)
Expand Down