Ondemand compilation doesn't take scalacOptions #1215
Conversation
mlachkar
force-pushed
the
on-demande
branch
2 times, most recently
from
c58b7dc to
d3592a4
Compare
mlachkar
changed the title
mlachkar
force-pushed
the
on-demande
branch
4 times, most recently
from
f4db66a to
468deb8
Compare
|
linked to this scalameta/scalameta#2094 |
|
Just landed on this and trying to understand the status: |
|
So if we pass the scalacOptions, it fixes the onDemand compilaton for 2.11 and 2.12, but not 2.13. So the bug is maybe on the reporter part. The bug is visible on scalameta too. |
|
Oh ok. I guess that's still something good to take in then (by removing tests for 2.13), and follow up 2.13 in another PR? |
mlachkar
force-pushed
the
on-demande
branch
2 times, most recently
from
0c4e8e8 to
e52b0f2
Compare
| val ss = new Settings() | ||
| val command = new CompilerCommand(scalacOptions, ss) | ||
| val settings = command.settings | ||
| settings.YpresentationAnyThread.value = true | ||
| settings.classpath.value = validatedClasspath.syntax | ||
| val reporter = new StoreReporter() |
There was a problem hiding this comment.
out of curiosity: is this block evaluated lazily on purpose to capture some state that it not available eagerly?
There was a problem hiding this comment.
So the creation of Global was lazy, I just put the entire block as lazy.
Usually, if the semanticdb file is present, global is never instantiated.
I don't think there is any state that is captured later..
| test("on-demand with scalacOptions") { | ||
| // Todo: Ondemand compilation doesn't take scalacOptions or the reporter doesn't gather all warns in 2.13 | ||
| // see https://github.com/scalacenter/scalafix/pull/1215 | ||
| if (ScalaVersions.isScala213) true |
There was a problem hiding this comment.
should we open a separate issue to track that?
No description provided.