Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure scalacOptions are honored in 2.13 #1344

Merged
merged 1 commit into from
Mar 2, 2021
Merged

ensure scalacOptions are honored in 2.13 #1344

merged 1 commit into from
Mar 2, 2021

Conversation

bjaglin
Copy link
Collaborator

@bjaglin bjaglin commented Mar 2, 2021 •
edited
Loading

Follows #1215
Confirms that scalameta/scalameta#2216 is fixed

@bjaglin bjaglin force-pushed the scalacoptions-213 branch from 13f49f8 to c1fd950 Compare March 2, 2021 15:30
@bjaglin bjaglin marked this pull request as ready for review March 2, 2021 15:31
@bjaglin bjaglin requested a review from mlachkar March 2, 2021 16:36
@mlachkar
Copy link
Collaborator

mlachkar commented Mar 2, 2021

That's really nice!

@bjaglin
Copy link
Collaborator Author

bjaglin commented Mar 2, 2021

That's really nice!

I ran into the scalameta issue for something else and it reminded me your PR!

I was looking for a ticket to close (#1215 (comment)), but I guess we didn't have any?

@bjaglin bjaglin merged commit 32a03fb into master Mar 2, 2021
@mlachkar
Copy link
Collaborator

mlachkar commented Mar 2, 2021

We had one scalameta/scalameta#2094, and they closed it, but I thought it was just because they were enabled to reproduce the issue.

@tgodzik
Copy link
Contributor

tgodzik commented Mar 2, 2021

We had one scalameta/scalameta#2094, and they closed it, but I thought it was just because they were enabled to reproduce the issue.

I managed to reproduce it and it should be fixed. Are you having still issues? The test from your PR is currently being run on all supported versions.

@bjaglin
Copy link
Collaborator Author

bjaglin commented Mar 2, 2021

Are you having still issues? The test from your PR is currently being run on all supported versions.

That PR shows that it's fixed upstream indeed, thanks!

What I meant is that I thought we had a ticket here to track the fact that we wanted to remove the scala 2.13 exception #1215 (comment), but it looks like no ticket was created.

@bjaglin bjaglin deleted the scalacoptions-213 branch March 26, 2021 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlachkar mlachkar mlachkar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bjaglin @mlachkar @tgodzik @github-brice-jaglin