revert unnecessary breaking change in testkit #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjaglin
referenced
this pull request
Nov 4, 2020
*except in test where we compile small virtual files
mlachkar
approved these changes
Nov 4, 2020
bjaglin
force-pushed
the
revert-breaking-change
branch
from
b3688a8 to
0bb614f
Compare
|
My change was not that clean. I can fix tests here if you want. |
bjaglin
force-pushed
the
revert-breaking-change
branch
from
0bb614f to
29b2dc7
Compare
bjaglin
commented
Nov 4, 2020
Comment on lines
+222
to
+223
| fullClasspath.in(testsInput, Compile).value.map(_.data) :+ | ||
| semanticdbTargetRoot.in(testsInput, Compile).value |
There was a problem hiding this comment.
similar strategy as in scalacenter/sbt-scalafix@cd9efb1
bjaglin
commented
Nov 4, 2020
| @@ -170,7 +170,7 @@ class CliSemanticSuite extends BaseCliSuite { | |||
| checkSemantic( | |||
| name = "-P:semanticdb:targetroot", | |||
| args = { | |||
| val (targetroot :: classDir :: Nil, jars) = | |||
| val (_ :: targetroot :: Nil, jars) = | |||
There was a problem hiding this comment.
not new to this PR, but the fact that order matters here shows that the test a bit fragile - I think it's acceptable as we don't put any ordering constraint for (external) testkit client, this is just a shortcut for fixturing, not a breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.