-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testkit: extract targetroot from scalacOptions #1406
Conversation
a6bc35c
to
3c57602
Compare
0835289
to
20b3be8
Compare
@@ -34,7 +34,7 @@ object Mima { | |||
ProblemFilters.exclude[Problem]("scalafix.testkit.SemanticRuleSuite.*"), | |||
ProblemFilters.exclude[MissingClassProblem]("scalafix.testkit.SyntacticRuleSuite$"), | |||
ProblemFilters.exclude[Problem]("scalafix.testkit.SyntacticRuleSuite"), | |||
ProblemFilters.exclude[ReversedMissingMethodProblem]("scalafix.interfaces.ScalafixArguments.withSemanticdbTargetroot") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unreleased
* client should not have to manually declare the semanticdb directories through the inputClasspath * rely on args.validatedClasspath for proper Scala 3 support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't think about having multiple targetroot directories.
I do prefer this approach for specifying semanticdbTargetRoot.
Me neither at first, and I didn't expect this PR to take me there (since it's about inferring it from We might want to expose |
Ok, let's do that like this, but I think if we start using |
Second take at #1275 leveraging #1389 (with the addition of the first preliminary commit, allowing the targetroot to be repeated in the CLI when dealing with a complex classpath)
Unlocks scalacenter/sbt-scalafix#219