Support Scala Native + Scala 3 #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix most warnings Update Scala 3 to 3.3.1 Update paiges-core to 0.4.3 Update Scala.js to 1.13.2 Update sbt-mdoc to 2.3.7
Move munit-scalacheck to test dependencies Add scalacheck as main dependency since it was used by the Compile scope and got as transitive dependency of munit-scalacheck
Fix scalacOptions for Scala 3 Fix more warnings Remove the various generated lazy val modJVM = mod.jvm
Scala.js doesn't implement java.io.File
|
@tgodzik The CI is finally green :) Can I ask you a review? |
tgodzik
approved these changes
Sep 30, 2023
|
Looks like the release is failing though https://github.com/scalameta/metaconfig/actions/runs/6364431764/job/17280704001 <- anything looks familiar? |
|
I'll give it a look tomorrow 👍 |
|
Opened #187 which should fix the problem on publishing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #179
Fix most warnings
Update Scala 3 to 3.3.1
Update paiges-core to 0.4.3
Update Scala.js to 1.13.2
Update sbt-mdoc to 2.3.7
Update scala-collection-compat to 2.11.0
Update munit to 1.0.0-M10
Remove munit-scalacheck from main dependencies
Add only scalacheck as a dependency
Update Scala Native to 0.4.15
Add Scala 3 to all projects
Move
java.io.Filespecific test tojvm-nativefolder