Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs to compile on Scala 3 #187

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Update docs to compile on Scala 3 #187

merged 1 commit into from
Oct 2, 2023

Conversation

lolgab
Copy link
Contributor

@lolgab lolgab commented Oct 2, 2023 •
edited
Loading

Now the docs project is also enabled for Scala 3.
It means that all the examples in the docs need to compile with Scala 3

@lolgab lolgab marked this pull request as ready for review October 2, 2023 10:19
@lolgab lolgab mentioned this pull request Oct 2, 2023
Merged
@lolgab
Copy link
Contributor Author

lolgab commented Oct 2, 2023

@tgodzik This should fix the publishing problem.

tgodzik
tgodzik approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏 !

@tgodzik tgodzik merged commit f2f1621 into scalameta:main Oct 2, 2023
@lolgab lolgab deleted the fix-docs-scala-3 branch October 2, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lolgab @tgodzik