meson: Add scx_lib dep to gen_bpf_o #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpftool is taken as a parameter but not used explicitly. Signed-off-by: Fredrik Lönnegren <fredrik@frelon.se>
This commit introduces a dependency on scx_lib in gen_bpf_o. Without this dependency the build fails intermittently with the following error: ``` FAILED: scheds/c/scx_pair.p/scx_pair.bpf.skel.h scheds/c/scx_pair.p/scx_pair.bpf.subskel.h /home/frelon/src/scx/meson-scripts/bpftool_build_skel /usr/sbin/bpftool scheds/c/scx_pair.p/scx_pair.bpf.o scheds/c/scx_pair.p/scx_pair.bpf.skel.h scheds/c/scx_pair.p/scx_pair.bpf.subskel.h /home/frelon/src/scx/build/lib/lib libbpf: failed to get ELF header for /home/frelon/src/scx/build/lib/lib.bpf.o: invalid `Elf' handle /home/frelon/src/scx/meson-scripts/bpftool_build_skel: line 25: 3400506 Segmentation fault (core dumped) "$bpftool" gen object "$stem".l1o "$input" "$lib".bpf.o ``` Signed-off-by: Fredrik Lönnegren <fredrik@frelon.se>
frelon
force-pushed
the
meson-bpftool-scx-lib
branch
from
f3d4576 to
a72c24e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a dependency on scx_lib in gen_bpf_o.
Without this dependency the build fails intermittently with the
following error:
Also updates a usage of bpftool to use the passed in path.