Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scx: add rustfmt.toml files to avoid lookup to $HOME/.rustfmt.toml #1069

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

likewhatevs
Copy link
Contributor

I think this fixes #1065

It looks like the issue is without a rustfmt.toml in every package dir, builds in arch's build system will try to read a format config file in HOME, causing a permission denied errors. IIUC, this should avoid that.

I also added a comment to the noop rustfmt.toml files so we know why they're there in the future.

@likewhatevs likewhatevs requested a review from htejun December 7, 2024 18:41
@likewhatevs
Copy link
Contributor Author

@ptr1337 can you see if this works? I'm not sure how to reproduce this failure but I think I follow what's going on and if I do, this should fix it.

@likewhatevs likewhatevs requested review from hodgesds and etsal December 7, 2024 18:41
@vnepogodin
Copy link
Contributor

@ptr1337 can you see if this works? I'm not sure how to reproduce this failure but I think I follow what's going on and if I do, this should fix it.

top level rustfmt.toml should be enough

@ptr1337
Copy link
Contributor

ptr1337 commented Dec 7, 2024

Thanks! The build was succesful with pkgctl:

==> Creating package "scx-scheds"...
  -> Generating .PKGINFO file...
  -> Generating .BUILDINFO file...
  -> Generating .MTREE file...
  -> Compressing package...
==> Creating package "scx-scheds-debug"...
  -> Generating .PKGINFO file...
  -> Generating .BUILDINFO file...
  -> Generating .MTREE file...
  -> Compressing package...
==> Leaving fakeroot environment.
==> Finished making: scx-scheds 1.0.7-1 (Sat Dec  7 19:49:35 2024)
==> Installing package scx-scheds with pacman -U...
loading packages...
resolving dependencies...
looking for conflicting packages...

@likewhatevs
Copy link
Contributor Author

likewhatevs commented Dec 7, 2024

Thanks! The build was succesful with pkgctl:

Could you confirm again with that latest change (updated w/ what @vnepogodin mentioned)?

also thanks for testing that!

@likewhatevs likewhatevs added this pull request to the merge queue Dec 7, 2024
@likewhatevs
Copy link
Contributor Author

will add in the extra rustfmt.toml's if needed, enqueueing this now because (per the pkgbuild I saw), this ought to work.

@ptr1337
Copy link
Contributor

ptr1337 commented Dec 7, 2024

Thanks! The build was succesful with pkgctl:

Could you confirm again with that latest change (updated w/ what @vnepogodin mentioned)?

also thanks for testing that!

That one works too. :)

Merged via the queue into sched-ext:main with commit 6d320bc Dec 7, 2024
23 checks passed
@likewhatevs likewhatevs deleted the fix-arch-build branch December 7, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Packaging fails when compiled in clean chroot
3 participants